Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-opencv-pip to obtain the newest version possible #41870

Closed
wants to merge 1 commit into from

Conversation

KozAAAAA
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

opencv-python

Package Upstream Source:

https://pypi.org/project/opencv-python/

Purpose of using this:

NMSBoxesBatched was added in a later version of OpenCV which is available only on PyPi.

Links to Distribution Packages

@KozAAAAA KozAAAAA requested a review from a team as a code owner June 28, 2024 08:29
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jun 28, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure that this is a good idea, particularly for libraries like this that we know are compiled. We are just dealing with ABI problems from another library where we accidentally mixed up a system-installed package and a ROS-specific package (see #41622).

Thus, my thinking here is that we should be heavily encouraging people to use the system-provided versions, and we shouldn't provide pip keys for things that the system already has. But I'll ask the rest of the team what they think about it.

@KozAAAAA
Copy link
Contributor Author

KozAAAAA commented Jul 1, 2024

So, what's the solution if this pull request doesn't get approved?

@clalancette
Copy link
Contributor

So, what's the solution if this pull request doesn't get approved?

You can use a local rosdep database in that case. See http://docs.ros.org/en/independent/api/rosdep/html/contributing_rules.html on how to do that.

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Jul 16, 2024
@clalancette
Copy link
Contributor

So we did discuss this, and the general thought was that we generally should not do this. It leads to too much confusion, and particularly in this kind of case, can lead to ABI problems.

So I'm going to close this out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants