fix default value for _workspaces in find_in_workspaces #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Dec 4, 2015
fix default value for _workspaces in find_in_workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767.
While this changes the behavior when being invoked with an explicit
Nonevalue this is hopefully not done anywhere 🙏A change to not change the default behavior in any case would be to choose a special default value (e.g.
_workspaces="some_default_value_nobody_is_guessing_and_using") but it doesn't seem to be worth in this case.