[Windows] Use raw string literal to accommodate escape characters #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 26, 2020
|
Cherry-picked to |
seanyen
added a commit
to ms-iot/catkin
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, CMake will use the backslash
\as the default character to compose the prefix path. However, when it is passed to the template, the\means differently as the escape character in Python. Therefore, a wrong string will be used in such case.Currently, to workaround it, one needs to explicitly define the prefix path like
set CMAKE_PREFIX_PATH=c:/opt/ros/noetic.This pull request is to use the raw string literal to remove the need of using forward slash in such case, so the default CMake would work directly with
catkin.