use single quote for cached environment values without old values #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I changed the logic a bit to what I hope is more readable and expressive. Please double check if this looks fine to you and still works for your use case. |
dirk-thomas
added a commit
that referenced
this pull request
Jul 24, 2020
) * use single quote for cached environment values without old values * add test for _set_variable with single_quote * update environment cache to test variable value with dollar sign * refactor logic * update test accordingly * fix tests Co-authored-by: Dirk Thomas <[email protected]>
|
Cherry-picked to |
|
@dirk-thomas Sorry for the delay. # <catkin_ws>/build/test_pkg/catkin_generated/setup_cached.sh
...
export ROSCONSOLE_FORMAT='[${severity}] [${time}] [${node}:${logger}]: ${message}'
export ROSLISP_PACKAGE_DIRECTORIES="/home/furushchev/catkin_ws_debug/devel/.private/test_pkg/share/common-lisp:$ROSLISP_PACKAGE_DIRECTORIES" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1107
By applying this pull request, exported values of environment variables are quoted using single quote sign.
For variables for paths with old values, double quote sign is used as before.