Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for pytest 5.1+ jUnit result files #1033

Merged
merged 3 commits into from
Oct 8, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #1032.

Copy link

@Rayman Rayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change with pytest 5.2.1 and it solves my problem. Thanks!

@dirk-thomas dirk-thomas merged commit 52bbba3 into kinetic-devel Oct 8, 2019
@dirk-thomas dirk-thomas deleted the dirk-thomas/support-pytest-5.1+ branch October 8, 2019 13:47
@mathias-luedtke
Copy link
Contributor

This fix does not seem to work with gtest results (example: ros-industrial/industrial_ci#599 (comment)) and counts all tests twice.
<testsuites> already summarizes the contained <testsuite> entries, so the code should not sum them up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest 5.1.0 generates incompatible xml output for catkin
3 participants