Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blacklist option to make_isolated #1027

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Add a blacklist option to make_isolated #1027

merged 4 commits into from
Aug 14, 2019

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Aug 14, 2019 •
edited
Loading

Add a blacklist option to catkin_make_isolated, e.g.

catkin_make_isolated --ignore-pkg foo bar

Fix #1026

dirk-thomas
dirk-thomas reviewed Aug 14, 2019
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this patch.

Just as a note: catkin_make_isolated is not being developed anymore. So you might want to look into using alternatives (colcon, catkin_tools) which already offer this (and many more) features.

python/catkin/builder.py Outdated Show resolved Hide resolved
bin/catkin_make_isolated Outdated Show resolved Hide resolved
bin/catkin_make_isolated Outdated Show resolved Hide resolved
python/catkin/builder.py Outdated Show resolved Hide resolved
@artivis
Copy link
Contributor Author

artivis commented Aug 14, 2019

@dirk-thomas Thanks for the review, PR updated accordingly.

@dirk-thomas dirk-thomas merged commit 0a8f356 into ros:kinetic-devel Aug 14, 2019
@artivis artivis deleted the feature/make_isolated_blacklist branch August 14, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Add a 'blacklist' option to catkin_make_isolated
2 participants
@artivis @dirk-thomas