Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3 version used by travis #1016

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 8, 2019

Travis now uses xenial as the default build environment. The CI uses system site packages, but this option only works with the default python 3 version. In xenial this version is python 3.5.

This PR bumps the python version to 3.5, and uses system_site_packages: true since that's what the travis documentation does.

Travis now uses
[xenial](https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment)
as the default build environment. The CI uses system site packages, but
this option only works with the default python 3 version. In xenial this
version is [python 3.5](https://packages.ubuntu.com/xenial/python3).

Signed-off-by: Shane Loretz<[email protected]>
@sloretz sloretz self-assigned this Jul 8, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Jul 8, 2019

Travis build passes: https://travis-ci.org/ros/catkin/builds/555875881

@sloretz
Copy link
Contributor Author

sloretz commented Jul 8, 2019

I'll merge this without waiting for an approval since it only changes .travis.yml, and appears to resolve the python 3 job issue.

If I overlooked something the worst case is it makes the travis CI on the kinetic-devel branch invalid. This wouldn't be a big deal because the branch is already covered by ROS PR jobs for python 2, and the python 3 travis job does not work without this PR.

@sloretz sloretz merged commit 1d1059c into kinetic-devel Jul 8, 2019
@sloretz sloretz deleted the sloretz/fix-travis-xenial-python branch July 8, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant