-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tf_conversions with tf2::convert #66
Conversation
CI is failing due to clang-tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup. To disambiguate the conversion direction, please use tf2::toMsg
and tf2::fromMsg
instead of tf2::convert
.
src/imarker_end_effector.cpp
Outdated
#include <eigen_conversions/eigen_msg.h> | ||
#include <tf_conversions/tf_eigen.h> | ||
#include <tf2_eigen/tf2_eigen.h> | ||
#include <tf2/convert.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is redundant
#include <tf2/convert.h> |
Closing and reopening to trigger Travis. |
Remaining clang-tidy issue is fixed in #68. |
merge? |
tf_conversions was still in use in one compilation unit