-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hideRobot to hide visualized robot state by setting hide_display in DisplayRobotState msg #56
Conversation
…ay in DisplayRobotState msg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also add the hook in the Rviz Display before merging this
src/moveit_visual_tools.cpp
Outdated
@@ -1517,22 +1517,14 @@ void MoveItVisualTools::publishRobotState(const moveit_msgs::DisplayRobotState& | |||
ros::spinOnce(); | |||
} | |||
|
|||
bool MoveItVisualTools::hideRobot() | |||
void MoveItVisualTools::hideRobot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see a reason to remove the bool and change API, please restore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Please, also restore the corresponding return value.
I forgot to mention this, but in this file we'll want to use code similar to this:
To disable when the msg flag is on |
This pull request should fix #52 after pull request #55 get merged.
@davetcoleman
@henningkayser