Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointCloud 1 support? #29

Open
botteroa-si opened this issue Mar 22, 2018 · 2 comments
Open

PointCloud 1 support? #29

botteroa-si opened this issue Mar 22, 2018 · 2 comments

Comments

@botteroa-si
Copy link
Contributor

botteroa-si commented Mar 22, 2018

Is support for PointCloud1 still needed even though PointCloud1 is deprecated?

In the first migration to ROS2 only the support for PointCloud2 is kept. If the PointCloud1 code is nonetheless needed in the future, it must be reintegrated.

@jonbinney
Copy link
Contributor

I lean towards not supporting pointcloud1, unless there is a strong need. Lets see how many people complain :-)

@vandanamandlik
Copy link

I am working on laser_assembler package porting to ROS2, in that PointCloud1 is used.
and as per maintainer's comment
"It would be good to keep support for both. It looks like ROS2 still has a PointCloud message: https://github.com/ros2/common_interfaces/tree/master/sensor_msgs/msg
The PointCloud message is simpler to use for people who aren't using PCL, since the PointCloud2 is a big binary blob that you have to manually parse." (ros-perception/laser_assembler#17)
We should keep support for PointCloud1.
So I copied PointCloud1 related things from indigo branch and ported it to ros2 and using it for laser_assembler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants