Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_saver only supports plumb_bob distortion model #1038

Open
sgillen opened this issue Oct 17, 2024 · 1 comment
Open

image_saver only supports plumb_bob distortion model #1038

sgillen opened this issue Oct 17, 2024 · 1 comment

Comments

@sgillen
Copy link

sgillen commented Oct 17, 2024

On humble (not tested elsewhere) when using image_saver with a camera info using for example, rational_polynomial distortion model, I will get the following error:

[ERROR] [1729187734.973433398] [camera_calibration_parsers]: Videre INI format can only save calibrations using the plumb bob distortion model. Use the YAML format instead.
        distortion_model = 'rational_polynomial', expected 'plumb_bob'
        D.size() = 8, expected 5

Maybe this is considered a bug with camera_calibration_parser, but it might be straightforward to just use a .yml/yaml extension here:
https://github.com/ros-perception/image_pipeline/blob/rolling/image_view/src/image_saver_node.cpp#L268C33-L268C49 

@mikeferguson
Copy link
Member

I think this should actually be ticketed upstream with camera_calibration_parsers - ideally anything we write out can be universally read back by other tools (which generally are going to be using the camera_calibration_parsers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants