Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should skipped tests result in a stable or unstable job ? #491

Closed
mikaelarguedas opened this issue Dec 20, 2017 · 1 comment · Fixed by #492
Closed

Should skipped tests result in a stable or unstable job ? #491

mikaelarguedas opened this issue Dec 20, 2017 · 1 comment · Fixed by #492
Labels
question

Comments

@mikaelarguedas
Copy link
Contributor

This came up in ros/ros_comm#1217 (comment)

Skipped tests are making jobs unstable the same way as failed tests:

ros_buildfarm/ros_buildfarm/templates/snippet/publisher_xunit.xml.em

Line 19 in 5634941

<unstableThreshold>0</unstableThreshold>

This is surprising to me as a user, as if I decide to disable a failing test I would expect my job to go from UNSTABLE to STABLE.
@mikaelarguedas mikaelarguedas mentioned this issue Dec 20, 2017
Merged
@mikaelarguedas
Copy link
Contributor Author

see #492 for a fix to not make jobs unstable in the presence of skipped tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not make job unstable if there are skipped tests ros-infrastructure/ros_buildfarm
1 participant
@mikaelarguedas