Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should public SSH key used by 'jenkins-agent' user be added to 'ssh_keys' section in 'common.yaml'? #29

Open
gavanderhoorn opened this issue Jan 23, 2018 · 1 comment

Comments

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Jan 23, 2018

Currently only the public key for the root user is added in the ssh_keys section of common.yaml. This allows passwordless logins over SSH to all hosts in a buildfarm (master, repo and slaves).

The comment above it is a bit cryptic:

The example public key should be changed but the private key has been deliberately deleted rather than leaked.

The trusty version of this had a second stanza in there for the public key the jenkins-slave user used to connect to the repo host (here).

Does the comment try to convey the fact that the public SSH key for the jenkins-agent user (to be used for logging into the repo host) should be added to the ssh_keys section there as well?

Or should it be added to the repo.yaml file, as this key should be imported on the repo host during deployment?

@gavanderhoorn
Copy link
Contributor Author

gavanderhoorn commented Jan 23, 2018

Without adding the public key for the jenkins-agent user I cannot get agents to upload results to the repo host (or at least: I cannot login over SSH to the repo host as the jenkins-agent user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant