Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPW kinematic parameters #61

Closed
marip8 opened this issue Jan 27, 2021 · 4 comments
Closed

OPW kinematic parameters #61

marip8 opened this issue Jan 27, 2021 · 4 comments

Comments

@marip8
Copy link
Member

marip8 commented Jan 27, 2021

Would it be beneficial to store OPW kinematic parameters in a file in the support packages for robot variants? They're not necessarily hard to set up (and the MoveIt OPW kinematics plugin has some helpful sanity checks for the parameters now), but it can be a bit confusing for those not familiar with the parameters or the means of figuring out what the parameters should be.

@gavanderhoorn
Copy link
Member

We've already done that for some support packages over in ros-industrial/fanuc. See ros-industrial/fanuc#284 (and ros-industrial/fanuc#293).

So: yes, we can do that, and we already have that in place for others.

@gavanderhoorn
Copy link
Member

@marip8
Copy link
Member Author

marip8 commented Jan 27, 2021

Fantastic; I'll close this issue since it's already been addressed. I have the parameters for the R2000iC165F; I can add those in a PR with the 125L variant. Is there a convenient way to reference this file in a MoveIt kinematics.yaml file, or would this just be for reference?

@marip8 marip8 closed this as completed Jan 27, 2021
@gavanderhoorn
Copy link
Member

I have the parameters for the R2000iC165F; I can add those in a PR with the 125L variant.

Could you please submit those in a separate PR? That way we keep PRs on-topic as much as possible.

Is there a convenient way to reference this file in a MoveIt kinematics.yaml file, or would this just be for reference?

Since moveit/moveit#1997 there is: in the UI of the MSA you can specify an "additional file" to load whatever parameters you need, which gets added to planning_context.launch.

If you have an existing MoveIt configuration pkg, you could just add the <rosparam command="load" file="$(find <your_pkg>)/config/opw_parameters_<variant>.yaml"/> line yourself in that file in the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants