Make thread_priority
a shared library
#91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library should be shared so other shared libraries can link it.
I discovered this during this PR: moveit/moveit2#1540
Note that the library I'm linking it to is another shared (aka dynamic) library.
Prior to this PR I get this error:
If you don't like the idea of making the
thread_priority
library SHARED, then another way to fix it is to add this to CMakeLists:set(CMAKE_CXX_FLAGS "-fPIC ${CMAKE_CXX_FLAGS}")