Citadel support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
ahcorde
approved these changes
Jun 25, 2021
ahcorde
added a commit
that referenced
this pull request
Dec 3, 2021
* Added ignition_ros2_control Signed-off-by: ahcorde <[email protected]> * Added ignition_ros2_control demos Signed-off-by: ahcorde <[email protected]> * Added github actions Signed-off-by: ahcorde <[email protected]> * udpate github actions Signed-off-by: ahcorde <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * update github actions Signed-off-by: Alejandro Hernández <[email protected]> * Fixed warnings Signed-off-by: Alejandro Hernández <[email protected]> * Update CI Signed-off-by: Alejandro Hernández <[email protected]> * Update CI Signed-off-by: Alejandro Hernández <[email protected]> * update README.md Signed-off-by: ahcorde <[email protected]> * Fixed color in xacros Signed-off-by: ahcorde <[email protected]> * Added missed dependency Signed-off-by: ahcorde <[email protected]> * Added missed dependency Signed-off-by: ahcorde <[email protected]> * use string option instaed of topic Signed-off-by: ahcorde <[email protected]> * Added Dockerfile Signed-off-by: ahcorde <[email protected]> * Improved README.md Signed-off-by: ahcorde <[email protected]> * Removed ignition-physics dependency and other minor fixes Signed-off-by: ahcorde <[email protected]> * Added some of the feedback Signed-off-by: ahcorde <[email protected]> * Write joints on each simulation update period Signed-off-by: ahcorde <[email protected]> * Ensure that sim_joints_ always has the same number of elements as the joint_names Signed-off-by: ahcorde <[email protected]> * Join with the controller manager's executor thread on exit Signed-off-by: ahcorde <[email protected]> * Forward sdf ros remappings to loaded controllers Signed-off-by: ahcorde <[email protected]> * Update ign_ros2_control Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Citadel support (#4) * Citadel compatible Signed-off-by: Louise Poubel <[email protected]> * cleanup Signed-off-by: Louise Poubel <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> Co-authored-by: ahcorde <[email protected]> * Added some fixes Signed-off-by: ahcorde <[email protected]> * fixed IMU Signed-off-by: ahcorde <[email protected]> * Use std instead of boost Signed-off-by: ahcorde <[email protected]> * Fortress support from cmake (#12) Signed-off-by: Vatan Aksoy Tezer <[email protected]> * Pass ROS time instead of SYSTEM time to update function Signed-off-by: ahcorde <[email protected]> * Fixed cmake and package Signed-off-by: ahcorde <[email protected]> * added feedback Signed-off-by: ahcorde <[email protected]> * Update License Signed-off-by: ahcorde <[email protected]> * typo Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * CI Signed-off-by: ahcorde <[email protected]> * remove fortress from CI Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Vatan Aksoy Tezer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignition-pluginrosdep keyUpdateInfo, so we're not relying on an Edifice featureI got as far as building against Citadel using
ros-foxy-ros-ign. But it crashes at runtime whenClassLoadertries to loadIgnitionSystemInterface. That's how far I got.I wasn't able to run the Edifice version. The Docker instructions hang for me, as well as building locally. I'm not sure how that would work. because
ros-foxy-ros-ignis compiled against Citadel, and the Docker image builds against Edifice. Does it work for you @ahcorde ?