From 68a81d338631ddb8b2a7498162c7817e02d9ce5a Mon Sep 17 00:00:00 2001 From: ahcorde Date: Tue, 30 Jun 2020 08:30:53 +0200 Subject: [PATCH] Added feedback Signed-off-by: ahcorde --- include/control_toolbox/pid_ros.hpp | 7 +------ src/pid_ros.cpp | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/control_toolbox/pid_ros.hpp b/include/control_toolbox/pid_ros.hpp index bb0f0da2..3eb416a7 100644 --- a/include/control_toolbox/pid_ros.hpp +++ b/include/control_toolbox/pid_ros.hpp @@ -55,7 +55,7 @@ class PidROS { public: /*! - * \brief Destructor of PidROS class. + * \brief Constructor of PidROS class. * * The node is passed to this class to handler the ROS parameters, this class allows * to add a prefix to the pid parameters @@ -88,11 +88,6 @@ class PidROS initialize(topic_prefix); } - /*! - * \brief Destructor of PidROS class. - */ - ~PidROS() = default; - /*! * \brief Initialize the PID controller and set the paramaters * \param p The proportional gain. diff --git a/src/pid_ros.cpp b/src/pid_ros.cpp index 002262bb..83c9ce18 100644 --- a/src/pid_ros.cpp +++ b/src/pid_ros.cpp @@ -78,6 +78,7 @@ PidROS::getBooleanParam(const std::string & param_name, bool & value) } } +// TODO(anyone): to-be-removed once this functionality becomes supported by the param API directly bool PidROS::getDoubleParam(const std::string & param_name, double & value) {