Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove "clippy" #39

Closed
njbart opened this issue Sep 19, 2019 · 6 comments · May be fixed by #41
Closed

Please remove "clippy" #39

njbart opened this issue Sep 19, 2019 · 6 comments · May be fixed by #41

Comments

@njbart
Copy link

njbart commented Sep 19, 2019

This is extremely annoying, and "limiting" the discussion is not in the least bit helpful.

Just get rid of it!

@KyleHaynes
Copy link

How is it limiting?

@p-phillips
Copy link

How is it limiting?
Because the original issue complaining about clippy was then set to only allow contributors to comment.

I agree that clippy is a PITA. I also spent some time trying to find out if I had an infected version of rstudio (and for a short while wondered if my workstation had been compromised when the damn paperclip started dancing over the man page) before I realised this was intended by the author of writexl.

writexl is excellent - clippy is a distraction I'm afraid.

@KyleHaynes
Copy link

Apologies ... scrap my comment, I misread it.

If users have such a gripe with it, perhaps take it up with CRAN regarding why they allow JS/CSS code to be added to HTML help docs, especially when it's externally sourced - potential security implications?

@zeehio
Copy link

zeehio commented Sep 30, 2019

Apologies ... scrap my comment, I misread it.

If users have such a gripe with it, perhaps take it up with CRAN regarding why they allow JS/CSS code to be added to HTML help docs, especially when it's externally sourced - potential security implications?

I have not seen complaints about general use of JS/CSS in this thread. Just about Clippy. Clippy behaves like those pop-up advertisements that do not offer an easy way to close them. So far no other CRAN package I've seen abuses JS/CSS in the documentation pages in this way. Wasting CRAN maintainers time in writing policy because this package abuses JS/CSS to play a joke on the user should not be the solution.

It's fine to make clippy pop up and play the joke on the user when we all laugh. I did laugh. It is not fine when the user does not find it funny anymore and he/she does not have an obvious way to disable it. It disrupts the user's attention.

Since this is free software, ropensci is free to not let us choose to disable clippy. But since this is free software, I can maintain my own fork of writexl that tracks writexl releases disabling the "feature" I don't like (I would happily include a close button, because I do find clippy funny sometimes, but I don't have the time to do that now so I'm just disabling it).

remotes::install_github("zeehio/[email protected]")

What a waste of time for everyone.

writexl is a great package (besides this), and I am very grateful to the developers for maintaining it.

@yaakovfeldman
Copy link

I think it's a great Easter egg. These are always controversial but have come into fashion at even some very large organisations. My only complaint is that it doesn't render correctly when a dark theme with light text is used in RStudio.

@aroman12
Copy link

Please remove it. I'm removing writexl until this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants