Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_etoxid() returns incorrect results for certain match types #201

Closed
4 tasks done
stitam opened this issue Jan 23, 2020 · 1 comment
Closed
4 tasks done

get_etoxid() returns incorrect results for certain match types #201

stitam opened this issue Jan 23, 2020 · 1 comment
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@stitam
Copy link
Contributor

stitam commented Jan 23, 2020

Match types available: "best", "all", "first", "ask", "na".

Reproducible example, try:
data("jagst", package = "webchem")
subs <- head(unique(jagst$substance))
get_etoxid(subs, match = "best")
get_etoxid(subs, match = "all")
get_etoxid(subs, match = "first")
get_etoxid(subs, match = "ask")
get_etoxid(subs, match = "na")

  • "all" returns an unformatted list
  • '"first"` seems shifted. doesn't print etoxid, match is na, distance is first
  • "ask" is not working
  • "na"should not return na for Desethylatrazin.
@stitam stitam changed the title get_etoxid() returns improper results for certain match types get_etoxid() returns incorrect results for certain match types Jan 23, 2020
@stitam stitam added the bug Unexpected problem or unintended behavior label Jan 23, 2020
@stitam stitam added this to the v0.5.0 milestone Jan 23, 2020
@stitam stitam self-assigned this Jan 23, 2020
@Aariq
Copy link
Collaborator

Aariq commented Jan 23, 2020

Let’s switch this to use chooser() internally?

@stitam stitam closed this as completed in 16b7da4 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants