-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fwildclusterboot presubmission #542
Comments
Hi @s3alfisc - thanks so much for submitting your package. I especially appreciate all of the details (and impressive benchmarking results!) in the best-in-class answer. As a general matter, this seems in-scope for a regression package. Based on your work with the statistical standards, could you please comment on whether you believe that the package is on track to meet at least half of the general + category-specific standards? Thanks also for the call-out on the optional functionality to call the Julia implementation. We are also planning, but do not yet have standards, for a statistical wrapper package. A member of the statistics peer review team may comment further on whether or not this package could fit that category also. |
Hi @emilyriederer , thanks for your feedback! I have uploaded my comments based on the statistical software roclets in a separate branch here . |
@s3alfisc @emilyriederer I've had a look through the code, and do not think this package should really be considered a statistical "wrapper" package, as it only constucts a single external call to one Julia package. The Julia connection is entirely optional for package functionality, and in terms of code and algorithms represents only a very small portion of the code. I suggest the review process can proceed under the single category nominated above. @s3alfisc I note that your current version documents compliance with 59 / 115 standards, which is > 50%, so okay to proceed. The |
Hi @mpadge , thanks for your feedback! I will spend some time cleaning up the package over the next days (documenting all srr roclets, add G.2.15, and merge everything into the main branch) and then I will submit |
@s3alfisc No need to merge if you'd rather not. We do want our system to one day work on non-default branches, so as said are happy to use your submission to test that, if that's easier for you. That said, we do generally advise against this, because then you'll be stuck implementing changes to reviews in your non-default branch, which may make your own workflow less robust. Up to you. |
Submitting Author Name: Alexander Fischer
Submitting Author Github Handle: @s3alfisc
Other Package Authors Github handles: @droodman,
Repository: https://github.com/s3alfisc/fwildclusterboot
Submission type: Pre-submission
Language: en
Scope
Please indicate which category or categories from our package fit policies or statistical package categories this package falls under. (Please check an appropriate box below):
Data Lifecycle Packages
Statistical Packages
Explain how and why the package falls under these categories (briefly, 1-2 sentences). Please note any areas you are unsure of:
fwildclusterboot
conducts inference for (linear) regression models via a wild (cluster) bootstrap. It further serves as an R binding of the WildBootTests.jl library.Yes, I have worked with the
srr
package and have a draft available (but it is currently not in the main branch).The target audience is academic social scientists (economics, political science, sociology).
fwildclusterboot
should be used whenever regression errors are "clustered" into few groups, in which case inference based on asymptotic approximations might fail.Other R packages that implement the wild cluster bootstrap are
sandwich
via itsvcovBS
function and theclusterSEs
package.fwildclusterboot
implements a significantly faster algorithm. Furter,fwildclusterboot
offers additional functionality, e.g. the subcluster bootstrap. ThroughWildBootTests.jl
, it also allows to run a highly optimized version of the WRE bootstrap for IV regressions (Davidson & MacKinnon, 2010) , which is not available in any other R package.(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
Yes.
Any other questions or issues we should be aware of?:
fwildclusterboot
implements the "fast" wild cluster bootstrap in R, but also allows to callWildBootTests.jl
via theJuliaConnectoR
package. It's therefore (also) a wrapper package, and you might consider it to be out of scope?The text was updated successfully, but these errors were encountered: