Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove anchors from RSS feed #80

Closed
maelle opened this issue Nov 13, 2020 · 14 comments
Closed

remove anchors from RSS feed #80

maelle opened this issue Nov 13, 2020 · 14 comments

Comments

@maelle
Copy link
Member

maelle commented Nov 13, 2020

they come from the render hook https://gohugo.io/getting-started/configuration-markup/#markdown-render-hooks

@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

@jeroen I was looking at GitHub READMEs for inspiration, and they also have the anchor in the HTML at all times. So I'm not sure we could solve this via CSS. Maybe I'll look another time 🤔

@jeroen
Copy link
Member

jeroen commented Nov 20, 2020

OK thanks. It already looks better on r-bloggers with the smaller icons: https://www.r-bloggers.com/2020/11/moving-away-from-travis-ci/

@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

It could only look better 😂 🙈

@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

bootstrap has classes special for print display, now I wish we could just add classes for R-bloggers display 🤔

@jeroen
Copy link
Member

jeroen commented Nov 20, 2020

I think the bootstrap class is equivalent of doing "style: display:none;"

@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

yeah but we want to do that only for rbloggers

@jeroen
Copy link
Member

jeroen commented Nov 20, 2020

For the rss feed you mean? I don't think any rss feed should contain anchor icons, not just r-bloggers?

@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

I think we don't have the issue with other feeds, at least not so much, because they use the summary rather than the whole content.

@maelle
Copy link
Member Author

maelle commented Nov 30, 2020

gohugoio/hugo#7160

@jeroen
Copy link
Member

jeroen commented Jan 29, 2021

The huge anchors also show up in our forum, if you click "show full post": https://discuss.ropensci.org/t/ropensci-behind-the-magick-updates-to-imagemagick-and-beyond/2329

@maelle
Copy link
Member Author

maelle commented Feb 1, 2021

Oops, this is not good indeed. @sckott how does this integration work? Could the link to full post direct to the website instead?
I am wondering where best to tweak this.

@maelle
Copy link
Member Author

maelle commented Feb 1, 2021

Also say we publish a post on the website, it gets re-posted on the forum, we update the post on the forum: does it get updated in the forum?

@sckott
Copy link
Contributor

sckott commented Feb 1, 2021

Here's the plugin for the integration https://github.com/discourse/discourse-chat-integration I don't see any way to change anything about the integration. I'm guessing most people don't read the post in the forum, but maybe they do

@maelle
Copy link
Member Author

maelle commented Feb 3, 2021

Thanks @sckott

@jeroen I'll try your idea to make the anchor an icon.

@maelle maelle closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants