Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning with vroom >= 1.5.0 #66

Closed
palderman opened this issue Feb 1, 2022 · 5 comments
Closed

Warning with vroom >= 1.5.0 #66

palderman opened this issue Feb 1, 2022 · 5 comments

Comments

@palderman
Copy link
Contributor

Current released version (4.0.3) is throwing a warning with readr::read_lines() and readr::read_csv() when running tests in my new R package under development at https://github.com/palderman/weathRman:

  The `file` argument of `vroom()` must use `I()` for literal data as of vroom 1.5.0.

  # Bad:
  vroom("foo\nbar\n")

  # Good:
  vroom(I("foo\nbar\n"))

Code to Reproduce
Clone my repo https://github.com/palderman/weathRman and run all tests Ctrl + Shift + T in RStudio IDE.

Expected behaviour
No warnings.

OS and R versions (please complete the following information):

  • OS: Linux, Ubuntu 18.04 LTS
  • R Version 4.1.2
@adamhsparks
Copy link
Member

I've merged the PR and submitted a new patch release to CRAN. I will close this when that version is accepted.

@palderman
Copy link
Contributor Author

Sounds good! Thanks for your work developing/maintaining this package.

@adamhsparks
Copy link
Member

Thanks for your help, I've noted your contribution in the authors list. https://docs.ropensci.org/nasapower/authors.html

I'll get in touch next time I'm in OK. My family lives in Stillwater now. :)

@palderman
Copy link
Contributor Author

Thanks for the acknowledgement.

What a small world! Please do reach out next time you are in Stillwater. I see from your ORCID profile that you are a plant pathologist by training and you spent some time in Toowoomba? Did you happen to interact with any of the APSIM modeling group there? I'm a crop modeler, myself, and have been interested in developing improved approaches for modeling crop-disease interactions. Anyway, it seems like we could have a fun conversation next time you are in town!

@adamhsparks
Copy link
Member

I’ve interacted with the APSIM folks, a good mate, still in Toowoomba is on the APSIM Panel and I’ve an APSIM modeller in my team here in Perth. I’ve been interested in ways of integrating disease loss functions into crop growth models, so yes, we probably could have a fun discussion next time I’m in town.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants