Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests with 'real API requests' to check if API or database changes #12

Closed
Selbosh opened this issue Nov 20, 2024 · 1 comment · Fixed by #13
Closed

Unit tests with 'real API requests' to check if API or database changes #12

Selbosh opened this issue Nov 20, 2024 · 1 comment · Fixed by #13

Comments

@Selbosh
Copy link
Collaborator

Selbosh commented Nov 20, 2024

There was a set of unit requests set to run daily, with the aim of flagging up if anything in the OC API or returned data changes, so that we can fix the relevant queries. However these have failed for a long time and I had to switch them off. Need to fix these, so that the package does not fail silently.

There are already unit tests based on pre-downloaded data but this is not robust to anything changing at the OpenCitations end.
@Selbosh
Copy link
Collaborator Author

Selbosh commented Nov 20, 2024

See GitHub action real-requests https://github.com/ropensci/citecorp/actions/workflows/real-requests.yml

@maelle maelle mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: update workflow files ropensci/citecorp
1 participant
@Selbosh