Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The handling of TPave options was incorrect. #17151

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

couet
Copy link
Member

@couet couet commented Nov 29, 2024

The handling of TPave options differed between TPave::PaintPave and TPave::PaintPaveArc. Specifically, in TPave::PaintPaveArc, the absence of one of the drawing options (TR, TL, BR, or BL) caused an incorrect shadow that completely obscured the TPave rendering. To address this, the default value when no valid drawing option is specified has been set to BR. Additionally, the NB option (no border) is now processed as documented in the TPave::Paint header.

@couet couet self-assigned this Nov 29, 2024
@couet couet requested review from dpiparo and linev November 29, 2024 16:20
Copy link

Test Results

    18 files      18 suites   3d 18h 41m 39s ⏱️
 2 687 tests  2 687 ✅ 0 💤 0 ❌
46 529 runs  46 529 ✅ 0 💤 0 ❌

Results for commit 917cfe6.

@dpiparo dpiparo merged commit b1470bc into root-project:master Nov 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants