Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Pull Request template for CLISOPS #70

Closed
Zeitsperre opened this issue Oct 1, 2020 · 2 comments · Fixed by #80
Closed

Add a Pull Request template for CLISOPS #70

Zeitsperre opened this issue Oct 1, 2020 · 2 comments · Fixed by #80
Assignees
@Zeitsperre
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Zeitsperre
Copy link
Collaborator

PRs could benefit from a template of questions that the contributor could answer. Some identifiers like "What does this PR change?" and "Are there breaking changes?" are things I've seen across GitHub and xclim has a few as well. I can add that at some point soon.
@Zeitsperre Zeitsperre added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2020
@Zeitsperre Zeitsperre self-assigned this Oct 1, 2020
@Zeitsperre Zeitsperre changed the title Add a Pull Request template top CLISOPS Add a Pull Request template for CLISOPS Oct 1, 2020
@agstephens
Copy link
Collaborator

Thanks @Zeitsperre. This will be great. (By the way, I'm loving pre_commit - can't believe I've not been aware of it).

@Zeitsperre
Copy link
Collaborator Author

@agstephens Glad to hear it! It really changed things up quite a bit when it was introduced in xclim. The number of PEP8-fixing commits dropped near zero. There are quite a few hooks available as well. Really neat development tool, for sure.

@agstephens agstephens mentioned this issue Oct 6, 2020
Closed
@Zeitsperre Zeitsperre mentioned this issue Oct 27, 2020
Merged
@agstephens agstephens mentioned this issue Nov 4, 2020
Closed
6 tasks
@agstephens agstephens mentioned this issue Dec 2, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zeitsperre Zeitsperre

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Pull request template and synchronize dependencies roocs/clisops
2 participants
@agstephens @Zeitsperre