Skip to content
This repository has been archived by the owner on Aug 19, 2018. It is now read-only.

RSocketServerTransport shutdown improvment #216

Open
artem-v opened this issue Jul 27, 2018 · 0 comments
Open

RSocketServerTransport shutdown improvment #216

artem-v opened this issue Jul 27, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@artem-v
Copy link
Contributor

artem-v commented Jul 27, 2018

Shutdown process of server transport is as following: ServerTransport.stop() closes server channel and all accepted client channels. While this mechanism serves its purpose this approach is rather exotic. Let's not have exotic code out of nowhere.

In this task:

  • Keep in stop() method just closing of server channel.
  • In order to shutdown entire service transport properly (account that all accepted connections must be closed) -- another system layer must be shutdown - a resources layer.

For reference look at io.scalecube.gateway.rsocket.websocket.RSocketWebsocketServer#stop

@artem-v artem-v added the enhancement New feature or request label Jul 27, 2018
@ronenhamias ronenhamias changed the title RSocketServerTransport shutdown mechanism must be refactored RSocketServerTransport shutdown improvment Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant