Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DLC and patch folders #1146

Closed
gen-angry opened this issue Sep 1, 2024 · 3 comments
Closed

[Bug] DLC and patch folders #1146

gen-angry opened this issue Sep 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@gen-angry
Copy link

gen-angry commented Sep 1, 2024

RomM version
3.5.0

Describe the bug
I have DLCs and patches for PC games stored in roms/win/(game)/dlc and roms/win/(game)/patch

Prior to 3.5.0, they used to be part of the file list within their folders. Now they no longer are and they don't show up anywhere else in the game page that I can see. It now just shows the base game files and nothing else.

Clicking download will download just the base game as well. It's like it's completely ignoring sub folders.

To Reproduce
Go to a game with /dlc and /patch subfolders.

Expected behavior
The DLC and patches included in the file list or even showing that they actually exist anywhere.
Downloading will include patches + dlc/expansions in the generated zip file.

Screenshots
Screenshot 2024-09-01 015421
^ previously, it would show expansion/Frozen Throne.zip and patch/War3TFT_127b_English.zip in the file list as well.

Desktop (please complete the following information):

  • OS: Win11
  • Browser Firefox
  • Version 129

Additional context
I read that there were pulls for integrating a new DLC handling system but I can't find any documentation on how it works or if it is finished. None of the game pages itself looks any different.

I could just drop the patches/expansions/dlc into the base game folder but I figured I'd post first to see if something's broken or needs to be documented before I do that to my whole library.

@gen-angry gen-angry added the bug Something isn't working label Sep 1, 2024
@gantoine
Copy link
Member

gantoine commented Sep 1, 2024

Duplicate of #228

@gantoine gantoine marked this as a duplicate of #228 Sep 1, 2024
@gantoine gantoine closed this as completed Sep 1, 2024
@gen-angry
Copy link
Author

gen-angry commented Sep 1, 2024

Duplicate of #228

I read that (and went down to find this) but it doesn't seem to do that, is that only enabled for switch roms?

Screenshot 2024-09-01 114728

File structure is now:

/roms/win/
- Warcraft III (WinXP CD)
-- Warcraft III - Reign of Chaos.zip
- Patches
-- Warcraft III (WinXP CD)
--- War3TFT_127b_English.zip
- DLCs
-- Warcraft III (WinXP CD)
--- Warcraft III - The Frozen Throne.zip

have also tried:

/roms/win/
- Warcraft III (WinXP CD)
-- Warcraft III - Reign of Chaos.zip
- patches
-- Warcraft III (WinXP CD)
--- War3TFT_127b_English.zip
- dlc
-- Warcraft III - The Frozen Throne.zip

and

- dlc
-- Warcraft III (WinXP CD)
--- Warcraft III - The Frozen Throne.zip

which get:
Screenshot 2024-09-01 115718

@gantoine
Copy link
Member

gantoine commented Sep 1, 2024

RomM doesn't support DLCs and patches in any way, tossing them into subfolders is good for organizing them, but we don't do anything special with them (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants