Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt-related API fixes and non-breaking changes #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BigInt-related API fixes and non-breaking changes #285

wants to merge 3 commits into from

Commits on Mar 10, 2022

  1. BigInt-related API fixes and non-breaking changes

    @mildsunrise
    mildsunrise committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    8732166 View commit details
    Browse the repository at this point in the history

  2. [BREAKING] convert [u]long & [u]int64 to BigInt 

    side-effects:
 - g_value_info_get_value() returns an int64, but enums
   are still 32 bit, so we need to cast to Number
    @mildsunrise
    mildsunrise committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    741732c View commit details
    Browse the repository at this point in the history

  3. fix conversions 

    turns out ToBigInt() and ToNumber() doesn't perform conversion
but only 'implicit' conversion which is not useful. create
helpers to extract the numbers from V8 and use them everywhere
(except in enum, flags, unichar)
    @mildsunrise
    mildsunrise committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    515d6a8 View commit details
    Browse the repository at this point in the history