🐛 Windows line endings break parsing of .gitignore

[m1212e]

On windows the CRLF line endings break parsing of the .gitignore files. This doesn't throw any error since a .git folder and an ignore file exist, its just that its contents arent parsed correctly.

I think this might be the relevant code snippet (rome/tools/crates/rome_cli/src/vcs.rs):

            if let Some((buffer, _)) = buffer {
                return Ok(buffer
                    .split('\n') // this should be platform agnotic or throw an error when CRLF is detected
                    // remove empty lines
                    .filter(|line| !line.is_empty())
                    .filter_map(|item| {
                        let line = item.to_string();
                        // remove comments
                        if !line.starts_with('#') {
                            Some(line)
                        } else {
                            None
                        }
                    })
                    .collect::<Vec<String>>());
            }

If you want I can create a pull request?

[ematipico]

Yeah, it would make sense to handle CRLF too when parsing the gitignore file. A PR would be great! Yes, that's the code 😁

[m1212e]

There you go: #4558