This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Move useTemplate
and useSimplifiedLogicalExpression
to style
group
#3461
MichaReiser
started this conversation in
Suggestions
Replies: 2 comments 1 reply
-
We could follow
If you check their Complexity group here https://rust-lang.github.io/rust-clippy/master/index.html (you need to select the filter), there's a bunch of rules around binary expressions. |
Beta Was this translation helpful? Give feedback.
1 reply
-
This proposal is implemented in #3471 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Question
To move the following rules to the stylistic lint group:
useTemplate
: Recommends using template literals over string concatenation. In my view, this is more a stylistic preference than preventing bugs (both variants can become difficult to read when they contain a lot or specially complicated placeholders).useSimplifiedExpression
: Helps to simplify logical expression. I can see the point how complex expression may increase the likeliness of bugs but sometimes comes down to how someone prefers to group logical expressions (arguably, it may then be recommended to create temporary variables).Recommendation
Rules to be in stylistic group
Beta Was this translation helpful? Give feedback.
All reactions