Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Panel disappear when rotating the screen in web brower #119

Closed
baneJack opened this issue Jan 8, 2021 · 3 comments
Closed

[BUG] Panel disappear when rotating the screen in web brower #119

baneJack opened this issue Jan 8, 2021 · 3 comments
Assignees
Labels
enhancement Extra attention is needed

Comments

@baneJack
Copy link

baneJack commented Jan 8, 2021

Unexpected behaviour:

  1. When I use web browser, depending of panel start position; the panel disappear or there is a shift when i rotate the screen.

  2. I display panel with elements list without hiding the bottom tab bar navigation, so when i scroll down the last element is hidden by the bottom bar. How to handle this case?
    How can we reproduce the effect when the scrollbar is in bottom position (as you gallery example in: https://github.com/roman-rr/cupertino-pane)

  3. Have you planned an event/callbacks that fire only when the scrollbar is in bottom position ?

@roman-rr roman-rr self-assigned this Jan 8, 2021
@roman-rr roman-rr added the enhancement Extra attention is needed label Jan 8, 2021
@roman-rr
Copy link
Collaborator

roman-rr commented Jan 8, 2021

Hello @baneJack thank you for issue!

  1. Good point to work around. I did schedule this as a feature/enhancement to set proper pane positions on window.resize callback.
  2. Try to play with topperOverflowOffset. Set some numbers, especially tab-bar height value.
  3. You are the first who's ask about this callbacks. I did not plan to include this callback into core, but if requests will appears frequently, i will do. Right now you can simply listen scroll bar element:
document.querySelector('SCROLL-ELEMENT').addEventListener('scroll', (s: any) => {
  console.log(s.target.scrollTop);
});

@baneJack
Copy link
Author

baneJack commented Jan 8, 2021

Thank you @roman-rr for your work and quick efficient response.

@roman-rr
Copy link
Collaborator

roman-rr commented Jan 21, 2021

@baneJack Orientation changes should be maintained automatically from 1.2.3 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants