Skip to content

Latest commit

 

History

History
71 lines (47 loc) · 4.92 KB

README.md

File metadata and controls

71 lines (47 loc) · 4.92 KB
Raw

deeper-sast-demo

The goal of this demo is to show the Sonar deeper SAST capabilities of the Java engine. We want to highlight that the usage of external libraries can introduce severe security vulnerabilities, which can be detected by Sonar deeper SAST.

Setup instructions

This repository is supposed to be added as a SonarCloud project for analysis via GitHub actions.

  • Fork this project with all branches (untick the default checkbox, "Copy the main branch only").
  • Go to the Actions tab of your forked repository and enable workflows by selecting I understand my workflows, go ahead and enable them.
  • Go to sonarcloud.io and sign up with your GitHub account.
  • Create a new organization under your name if there is none.
  • Give SonarCloud permission to see the forked repository.
  • Add your repository as a new Project.
  • Go to Administration -> Analysis Method and uncheck Automatic Analysis.
  • Select Set up analysis via other methods -> With GitHub Actions.
    • Add the displayed GitHub Secret to your repository.
    • Update the sonar.organization value in the pom.xml file.
    • Create a new file.github/workflows/build.yml, copy & paste the displayed content to it.
    • Set the java-version in the build.yml file to 17.
  • On your GitHub repository: Go to the Pull requests tab and create a new PR from the introduce-user-migration-feature and allow-imports branches to the main branch of your fork. Be careful that, by default, the PR targets the upstream repository.

The first two issues will be displayed on the main branch and the other two issues on distinct Pull Requests.

Storyboard

The demo is a fictive Spring application implementing different functionalities which are vulnerable to security issues detected by our engine. All of these issues contain at least one step where the data flow:

  1. originates from a user-controllable source within a library,
  2. passes through a library, or
  3. ends in a dangerous sink within a library.

Thus these issues are only detected because of the deeper SAST feature of the Sonar engine.

There are four issues: two of these are already committed to the main branch of the application. Additionally, there are two pending pull requests (PR), which each introduce another vulnerability. For these issues, the chosen examples aim to demonstrate that the proposed source code in the PR does not look dangerous or security-sensitive and would likely be merged.

Issue 1 - Session Cookie Handling (main branch)

  • Vulnerability Type: Deserialization (S5135)
  • Deeper SAST Dataflow:
    • Passthrough: org.apache.commons.codec.binary.Base64.decodeBase64

This vulnerability resides within the session cookie handling of the application. A vulnerability is introduced by deserializing user-controllable data from a header (Session-Auth), which can be exploited to execute arbitrary code. The data provided in the header is passed through the decodeBase64 library function before being deserialized.

Issue 2 - User Images (main branch)

  • Vulnerability Type: Path Injection (S2083)
  • Deeper SAST Dataflow:
    • Source: org.springframework.web.context.request.getRemoteUser
    • Passthrough: org.apache.tomcat.util.buf.UDecoder.URLDecode
    • Sink: cn.hutool.cache.file.LRUFileCache.getFileBytes

This vulnerability resides within the code responsible for retrieving user images. The library function getRemoteUser is used to retrieve the user-controllable username, which is passed through the URLDecode library function. The result is concatenated to a file path, which is passed to the getFileBytes library function introducing a path injection vulnerability.

Issue 3 - User Migration (PR 1 - Introduce user migration feature)

  • Vulnerability Type: SQL Injection (S3649)
  • Deeper SAST Dataflow:
    • Sink: com.mysql.cj.jdbc.ConnectionImpl.setSavepoint

This PR adds a feature to migrate users from the existing H2 database to MySQL. Although the proposed change does not seem to contain any vulnerabilities, the setSavepoint library function is vulnerable to SQL injection if the passed argument is user-controllable. Thus this PR introduces a critical vulnerability due to the usage of the unsafe library function.

Issue 4 - XML User Import (PR 2 - Allow the import of users)

  • Vulnerability Type: Deserialization (S5135)
  • Deeper SAST Dataflow:
    • Sink: ca.odell.glazedlists.impl.io.BeanXMLByteCoder.decode

This PR adds a new feature to import users from an XML file. Although the code itself does not seem to contain any vulnerabilities, the decode library function is vulnerable to deserialization if the passed argument is user-controllable. Thus this PR introduces a critical vulnerability due to the usage of the unsafe library function.