Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte dependancy #25

Closed
Kiho opened this issue Dec 9, 2017 · 4 comments
Closed

Svelte dependancy #25

Kiho opened this issue Dec 9, 2017 · 4 comments

Comments

@Kiho
Copy link

Kiho commented Dec 9, 2017

I have hard time figuring out why my code referencing from local repo is not working.

"dependencies": {
....
    "svelte": "^1.46.0"
  }

Is this necessary to be there? or can this can be behind? last was 1.25.0 then jump to 1.46.0

@Rich-Harris
Copy link
Member

I'm not sure I understand what problem you're experiencing?

One thing I've thought about doing is moving svelte to peerDependencies. That way you would have to install it separately, but you'd have total control over which version was used.

@Kiho
Copy link
Author

Kiho commented Dec 9, 2017

My problem was this https://github.com/Kiho/svelte-redux-zero/blob/context-destroy/package.json#L28
was not working, this plugin is overriding that and installs 1.46.0.
I had to change "rollup-plugin-svelte": "^3.1.0" to "rollup-plugin-svelte": "~3.1.0"

@Rich-Harris
Copy link
Member

I see. That would probably be fixed by using peerDependencies, I think

Rich-Harris added a commit that referenced this issue Dec 17, 2017
move svelte to peerDependencies
@Rich-Harris
Copy link
Member

I've just released version 4 of this plugin — Svelte is now in peerDependencies, so hopefully this won't arise again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants