From 18afe15f44f07964150d2580e92709bb5e7aa8a6 Mon Sep 17 00:00:00 2001
From: Justin McMurdie <3059715+TheMcMurder@users.noreply.github.com>
Date: Fri, 15 Apr 2022 06:52:11 -0600
Subject: [PATCH] =?UTF-8?q?fix(node-resolve):=20update=20side=20effects=20?=
 =?UTF-8?q?logic=20to=20be=20deep=20when=20glob=20doesn=E2=80=99t=20contai?=
 =?UTF-8?q?n=20`/`=20(#1148)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* feat(node-resolve): deep side effects option

* chore(node-resolve): Fixing linting errors

* feat: deep side effects - prevent changes when side effects start with "./" || "/"

* feat: support deep side effects by default - matching webpack implementation

* chore(cleanup): pr feedback
---
 packages/node-resolve/src/util.js             |  12 ++++++-
 .../deep/side-effect.js                       |   1 +
 .../index.js                                  |   4 +++
 .../package.json                              |   4 +++
 .../shallow-side-effect.js                    |   1 +
 .../deep-side-effects/deep/side-effect.js     |   1 +
 .../test/fixtures/deep-side-effects/index.js  |   4 +++
 .../fixtures/deep-side-effects/package.json   |   4 +++
 .../deep-side-effects/shallow-side-effect.js  |   1 +
 .../node-resolve/test/snapshots/test.js.md    |  24 +++++++++++++
 .../node-resolve/test/snapshots/test.js.snap  | Bin 1459 -> 1618 bytes
 packages/node-resolve/test/test.js            |  32 ++++++++++++++++++
 12 files changed, 87 insertions(+), 1 deletion(-)
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/deep/side-effect.js
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/index.js
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/package.json
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/shallow-side-effect.js
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects/deep/side-effect.js
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects/index.js
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects/package.json
 create mode 100644 packages/node-resolve/test/fixtures/deep-side-effects/shallow-side-effect.js

diff --git a/packages/node-resolve/src/util.js b/packages/node-resolve/src/util.js
index 7b21d250a..c61deb27d 100644
--- a/packages/node-resolve/src/util.js
+++ b/packages/node-resolve/src/util.js
@@ -144,7 +144,17 @@ export function getPackageInfo(options) {
     if (typeof packageSideEffects === 'boolean') {
       internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
     } else if (Array.isArray(packageSideEffects)) {
-      internalPackageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {
+      const finalPackageSideEffects = packageSideEffects.map((sideEffect) => {
+        /*
+         * The array accepts simple glob patterns to the relevant files... Patterns like .css, which do not include a /, will be treated like **\/.css.
+         * https://webpack.js.org/guides/tree-shaking/
+         */
+        if (sideEffect.includes('/')) {
+          return sideEffect;
+        }
+        return `**/${sideEffect}`;
+      });
+      internalPackageInfo.hasModuleSideEffects = createFilter(finalPackageSideEffects, null, {
         resolve: pkgRoot
       });
     }
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/deep/side-effect.js b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/deep/side-effect.js
new file mode 100644
index 000000000..a9932c054
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/deep/side-effect.js
@@ -0,0 +1 @@
+console.log('deep side effect')
\ No newline at end of file
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/index.js b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/index.js
new file mode 100644
index 000000000..2b08cba9b
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/index.js
@@ -0,0 +1,4 @@
+import './deep/side-effect.js'
+import './shallow-side-effect.js'
+
+console.log('main')
\ No newline at end of file
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/package.json b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/package.json
new file mode 100644
index 000000000..1254bc8ae
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/package.json
@@ -0,0 +1,4 @@
+{
+  "main": "./index.js",
+  "sideEffects": ["./*.js"]
+}
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/shallow-side-effect.js b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/shallow-side-effect.js
new file mode 100644
index 000000000..dd89c4709
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects-with-specific-side-effects/shallow-side-effect.js
@@ -0,0 +1 @@
+console.log('shallow side effect')
\ No newline at end of file
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects/deep/side-effect.js b/packages/node-resolve/test/fixtures/deep-side-effects/deep/side-effect.js
new file mode 100644
index 000000000..a9932c054
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects/deep/side-effect.js
@@ -0,0 +1 @@
+console.log('deep side effect')
\ No newline at end of file
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects/index.js b/packages/node-resolve/test/fixtures/deep-side-effects/index.js
new file mode 100644
index 000000000..2b08cba9b
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects/index.js
@@ -0,0 +1,4 @@
+import './deep/side-effect.js'
+import './shallow-side-effect.js'
+
+console.log('main')
\ No newline at end of file
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects/package.json b/packages/node-resolve/test/fixtures/deep-side-effects/package.json
new file mode 100644
index 000000000..cef46cb21
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects/package.json
@@ -0,0 +1,4 @@
+{
+  "main": "./index.js",
+  "sideEffects": ["*.js"]
+}
diff --git a/packages/node-resolve/test/fixtures/deep-side-effects/shallow-side-effect.js b/packages/node-resolve/test/fixtures/deep-side-effects/shallow-side-effect.js
new file mode 100644
index 000000000..dd89c4709
--- /dev/null
+++ b/packages/node-resolve/test/fixtures/deep-side-effects/shallow-side-effect.js
@@ -0,0 +1 @@
+console.log('shallow side effect')
\ No newline at end of file
diff --git a/packages/node-resolve/test/snapshots/test.js.md b/packages/node-resolve/test/snapshots/test.js.md
index 844b66a7c..de7267431 100644
--- a/packages/node-resolve/test/snapshots/test.js.md
+++ b/packages/node-resolve/test/snapshots/test.js.md
@@ -176,3 +176,27 @@ Generated by [AVA](https://avajs.dev).
     Error {
       message: 'node-resolve: `customResolveOptions.packageIterator` is no longer an option. If you need this, please open an issue.',
     }
+
+## respects the package.json sideEffects property for files in the root package and supports deep side effects
+
+> Snapshot 1
+
+    `'use strict';␊
+    ␊
+    console.log('deep side effect');␊
+    ␊
+    console.log('shallow side effect');␊
+    ␊
+    console.log('main');␊
+    `
+
+## does not prefix the sideEffects property if the side effect contains a "/"
+
+> Snapshot 1
+
+    `'use strict';␊
+    ␊
+    console.log('shallow side effect');␊
+    ␊
+    console.log('main');␊
+    `
diff --git a/packages/node-resolve/test/snapshots/test.js.snap b/packages/node-resolve/test/snapshots/test.js.snap
index 956e33b1a44fa8907def64051a9db40f8b7a0588..83f4e677a760ab0f96a3c69163da2314b484aff0 100644
GIT binary patch
literal 1618
zcmV-Y2Cex)RzV<BZeeh9Xm4~Nb}|YA0Lg6u(r@82sHkaQvyc?sJRge)00000000B+
zS9@#}MHrvCzK*u^0i`L1$3&15?A^r{f)p_+w8bm*ihWRs)OPP~dbjP~?y-+v8>j*X
zZ2?iKk5o+%B{l>UqC8SX0wnTK5hYj+LBJ|R@ec(QOfcxT)7z#GDF<n_CSLN(&i=lc
z+4;Wj_sz^bZbB#xMI;~0y8ivC%JJsbEyXv|c4MUfz5v8zoO~|kRQbg$YR%ijCzfNz
zz6u@8o93y>jUUfHy3%`a%8u<DF=O2@U-HNUv)3%27I|siM`I(ApT~@y9)VEmwGT$;
zzjXF$R?F-c9VspuGZsf8H14E)Wo^lQspZPbl^2e;7h}dA0ZcyPz1DcTb;h>!Ckie{
z@3mpZW=A1py=!S(#dh`3cl+;tqq*YKI?UK-V-U(Lh;8af$=tbOR_&2ZEo+Wp#-0Jp
zia&h(fhp#e=C<I|`%~*a!HnH%MyM+Da$rn*Yhq<h)Z+5PUww-iTOJFRW+C{(!j{Kk
z?62+luyWP=n6Z=M5UREBRy)4lvGl}eQ(a>U4vQwnHiU2z(6sEzJx@MzsJZm>C%nZ^
zO-#d#eKQ`RwWAKaoF}wLC1`Jt*wyA-h8cT&I6~`w`lU%ISDrt8VDF=ojy5)9#!gB=
zXnk4MvHZ+7H2#NHdm!b#d6=;cfDMcGE^+2Bdg$t(%Y}}(_9Dz!M<PO-y<ZmkJWa(W
zOX0!#l6SXa#*Rut=&dc^EL_rYqioulM&(d}2{Nd&zXP^qM2?*~VPonm*)`j;f4=Yx
zX6%$?gx)#ljGsN@{H5zthyRg-e$2&;y#m;oGxc1<u8lV`B(!S1C*fDj*!&R)on1EJ
z=|vaOnT~PA>f#L%7cgVj03uKfQyNagrs?pU1sI7<$v7%kmL+*4jy9SY8?B_IB!q_}
z3<^oqJE!0XgrkyijGrnB=cUHGDoP$|m8l{LwKR)Vx-~_W{6(Gbg#ne9M8y{1+%+)9
zp;DPsCApID3K1nDNTQd@gcFIxI@*Y%iquOQ5h?W$)yFI8Bp^^uq0oVfdPiPSG-?}6
zhy39<BvVcZaH?-edr}jQC%lr!3v@{P5e&-@(Jg2mI!BUef#lHystjqL!d01P$Y-ZI
zybVD04PZi|5UAUtK?g;ZdADkr85`?{???i*36l3-i-*zxQFsp}w5p0ihsnKrC_YXQ
zq+tJ@{2VXpY}bd)*pv>>3>H5<XxXyN)w7_nR$^iz!m%u9aTq^n42lWDvjMOba9(f2
z8NL~?4~Hg-E_7AH67-yennwJid&NJ}4e>T!l1rUMxy6O^7v|<vI0_aN7M1ksZRY&}
zNrrvbAV%w<v39anQ4+0wRxP$_<raCavs6ivT_0`H^B9`fLtORbrc<U9m!=Z8qzN8K
zyh>b@goNTD9V?oN3JO<w(Mx!haEhL2S_f+tIRWN`)O)DtuJ5(3XhqUwch|Da#;Oob
zz}Nyepe~Cl6@xlNZ?6d=G+8j(1wK^`C|P#9ED3@Zs8(!}?6rF}5QUwJ_6b2w7GVaf
zvCxofR!*@RE46lC>1b9~ohdcvX`)-#H;(A`0%`3b<Lv%qe0$;?gyIf_cZB5dGAvP&
z>j$pH@37LMBzS6o*8zD@T}y9WVUhh+Si*w&rE?w5in8n?r^7k7|9F{Jqn-gP@zI+E
zty4(d0@oQR;)6PHQ3wgh3Tzydn2nS|oGN>c;NgHvCqW<Y_7OjPK(8%`BB#g3*1Kc^
zg68E#<2Anf8d=$_#eZ8ix2NVoke?8a{9K?S4?lpHO1&%{{g&k&ogITT?I46*zKuIQ
z+)rR19LTyK_Aor103NU!unDjaa0>7nAPL`MPcS1Kulv`f=~z}4`c8d+$b@lUTc%+%
z^|ehiY!QYnuG7ZD)?a5BBfADxae_j7d@#ze4O3;UrzyIRDZ?<ubj`?2>}&rE)p(b}
zy?YL{O8+fi^h<}R=*^+*OP^!#CW!$%m1}8ny<gzPntog=qre9VCj_~Ah3Lvu;b85&
zvysZa^MuCrQ1rz96#Y+#HLSxdw5$Fn4zr9oT^IY1SHxno!+qRBs$|JeG|{;1TLsC@
Q3Gj#DFNoVEv<MXd0B)ERIsgCw

literal 1459
zcmV;k1x)%uRzV<BZeeh9Xm4~Nb}|YA08KiDg-w2fFK9I*D)M{-<sXX(00000000Bc
zR(otyRTw{~kF{)LT^%l91Wz2MifbD;2|C0$V8bEnaNT$$jP<rXYwvb@Pq`1e28^IV
zUYZ!@BU2N^5Rm|4j7so9fJDGo&;(~fBIpDX`NtrNe_+t>p7u6-$SBDsyUCYx&hI<t
z-0yw9KQKaN$m%{?bM@Tm&|S`5yMxyze*_?W-vK$QPQB<j-FC5tdg~8}t~Sik*I|Qm
z#}k@+)0d0BSRXq&<GuacF-Id7gxqCE=5AR#({}0k&!^f@Lc|=MWksm`uTQ2deC6zw
zn%=oDH%tmEn4{Q+(6m#^<*hCEm$#|w*Izi<7sMPr0pz`7)xq}t+Ob~_-~Cok``6u=
zqvZ~Ssv8S8_fM++VBMV6CwBC1`37^80?jEte)6Fi&fcDbsf~xryT8I5t#TsNQT==J
z&c0o)P?vpq+wmWM#vDC20XRKU>ZK*UD;@qf4ty4R=3~s!eT4{ZUUT`LXP-RQ)B5ex
zvEXylCu5GTEkbDP?MGg%m-_4_`o7yfJQ!GmIr>g9Lfe*ox+1V}*`rtfSu6Dy^)+LT
zY7-IK8T-B|9^D+Yc$$u;Ti)M;Ir>-$LT~T>amkAQYfERI*`yw8w17now8DkZ-YVPF
z*%jN%U#sofTl?FE7cfU#f!_ToP(1hH^OvqZIPvfK=+`>T(P^a!on2G0aoI(5rhi&c
zTfWVD0dsUEkQF(&fAM5&nFZq<pfYT6V|$&VFr^F^m{W|+S!ro0!V?h&zqpLeldu(G
zyBj+aR8@r-HP@QVqSUKUl}W2<4GBebRbz?f%(^M5iA+{~Ng>h&XBsrB2pUsDL{y2)
zh{WU=Rfr%H#y9#%LkCGSoye3%i53^tN|KbQpi<aCWn-hLsyg+Jr9z2(6jG=lB?T=$
zt~Ke(M-x%47bQBb^+@HVha8dgD4oX?+Q_21MAdPvQ@&9a9rxbp%&!1w@lkY$6I&`_
ztm0}Ivezn#kmj=UnakxuxRA?Ugz+QhAx8?vr-1eVoj2z2fb9f2gtHeFG=)29L^Dj2
zotkDS7-9xn1k^Sc?$$taU9f4<lDhfr4ULPNnp=kKc8ZB4Q=t5rz?3MZNpA-A%1rhq
zc+mPf)f<?*+tb0A-#G0t%$dD6O2TP!-770eSl38|=~5KzuaPh%S${=I|GFNcL7-`(
z93!Ge1l6!N?FLz8L4rHM15qkR(nI7bP?@eoa$-46sSqx~*aOdhj-#=lroin(F0kr~
zWX>DonwC^+{C<T=lAi2TeN2h@W4ainek%JbQi3AG4PH~wtZH6C^_r4;2TD4HM|Z}h
z&U#&r7-5F30~X-cTr}B{8`pYt2saf3jcA_Pg@qA_S_a0GSnOVp3UUzI(E;J$xo;>l
zA&9bpj%AJ|^Q+|ZMFm7;O8S;(nw`O@1HB1U581Wq#u;WCDZ@$@FKS)T5NKao+Z<>J
zEEw5dmJMjI!CK<<I!4O`(g4F{3`OFQ2Vn{(fv^Ie04e4ptzf6n;1eReGnFJ27b9_!
zfFBsS1y&Rc+xUj2Oj6QgqHHdU2g=CPW-I>Bw7I!x9)s|c@(I5%L{U^6-@To36U{0-
zyii$2Gm|Df4r2gF1lj<!1LzRYX`nxWO7RV{%!zQZp<gaa3VEOzweNu}3*+IuYLjOf
z&YNlStR}B0!xN#HcAHFF?qG)?sdUf}?Iv%6rs#uN1;bcXCd-k#k+b;U#?tjH-!^5m
z{eG)-F&;))HKyZPmtm#)I*tK8RaVnrIw6U2*9a;trGTf1Af<$~N{mNcgW{j*D@bVg
zJ=t@Ent|yfH3R?0d!JXq&DN>W^RA(K)x2DnnEgHR`25h^c}R!C5=58H&e1Eeh#*0C
N`7eWZv|>^c0017O$PEAh

diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
index 0979eb76a..50cbcac82 100755
--- a/packages/node-resolve/test/test.js
+++ b/packages/node-resolve/test/test.js
@@ -322,6 +322,38 @@ test('respects the package.json sideEffects property for files in root package b
   t.snapshot(code);
 });
 
+test('respects the package.json sideEffects property for files in the root package and supports deep side effects', async (t) => {
+  const bundle = await rollup({
+    input: 'deep-side-effects/index.js',
+    onwarn: failOnWarn(t),
+    plugins: [
+      nodeResolve({
+        rootDir: 'deep-side-effects'
+      })
+    ]
+  });
+  const code = await getCode(bundle);
+  t.true(code.includes('shallow side effect'));
+  t.true(code.includes('deep side effect'));
+  t.snapshot(code);
+});
+
+test('does not prefix the sideEffects property if the side effect contains a "/"', async (t) => {
+  const bundle = await rollup({
+    input: 'deep-side-effects-with-specific-side-effects/index.js',
+    onwarn: failOnWarn(t),
+    plugins: [
+      nodeResolve({
+        rootDir: 'deep-side-effects-with-specific-side-effects'
+      })
+    ]
+  });
+  const code = await getCode(bundle);
+  t.true(code.includes('shallow side effect'));
+  t.false(code.includes('deep side effects'));
+  t.snapshot(code);
+});
+
 test('ignores the package.json sideEffects property for files in root package with "ignoreSideEffectsForRoot" option', async (t) => {
   const bundle = await rollup({
     input: 'root-package-side-effect/index.js',