Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Training Program #569

Open
Quiddlee opened this issue Sep 27, 2024 · 0 comments Β· May be fixed by #661
Open

FSD: Widget Training Program #569

Quiddlee opened this issue Sep 27, 2024 · 0 comments Β· May be fixed by #661

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 27, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/training-program

βœ… Definition of Done (DoD):

training-program.module.scss

  1. Refactor scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image
  • remove commented code

training-program.tsx

  1. replace interface with type
  2. move localized content to dev-data folder
  3. remove TODO comment (leave everything as it is)
  4. replace div's with HTML5 tags
  5. replace ternary operator in className with classnames
  6. change import type CourseName from .data to type CourseName from src/shared/types.ts

training-program.test.tsx

  1. move test file to ui folder
  2. replace enroll link with constant

training-program.data.tsx

  1. remove type CourseName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Peer review
Development

Successfully merging a pull request may close this issue.

1 participant