Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streamer for input-range like types #317

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Fix streamer for input-range like types #317

merged 4 commits into from
Oct 7, 2023

Conversation

DNKpp
Copy link
Contributor

@DNKpp DNKpp commented Oct 6, 2023

As discussed #313

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1c5cb72) 98.00% compared to head (ad428fa) 98.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files           1        1           
  Lines        1356     1356           
=======================================
  Hits         1329     1329           
  Misses         27       27           
Files Coverage Δ
include/trompeloeil.hpp 98.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DNKpp
Copy link
Contributor Author

DNKpp commented Oct 6, 2023

Ah, lovely. Will try to fix that :)

@rollbear
Copy link
Owner

rollbear commented Oct 6, 2023

If you want to use them, the docker containers with the various compilers are available at ghcr.io/rollbear/gcc and ghcr.io/rollbear/clang, e.g. docker pull ghcr.io/rollbear/gcc:4.9. See https://github.com/rollbear/ci_compilers/ for info on how to use them. Be careful with using them for other purposes - I change them randomly for whatever reason.

@DNKpp
Copy link
Contributor Author

DNKpp commented Oct 7, 2023

Well, thanks. Hopefully it's working now. Never thought, that such a trivial code will be broken on c++11 conforming compilers.

@rollbear
Copy link
Owner

rollbear commented Oct 7, 2023

Yeah, trying to get something to work with such a wide range of compilers of various ages can be quite challenging. Thank you so much for this fix.

@rollbear rollbear merged commit 13b6433 into rollbear:main Oct 7, 2023
172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants