Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds support for
psr/log
version 3. This has been a long-standing issue but could not be fixed without causing breaking changes. See #536 for a discussion.I renamed the
log()
method in bothRollbar
andRollbarLogger
classes toreport()
. Newlog()
methods were then created that were compliant withPsr\Log\LoggerInterface
. Since thereport()
methods are not defined in thepsr/log
interface we can return theResponse
object. This is very important for testing purposes.Almost all unit tests that used
Rollbar::log()
orRollbarLogger::log()
were updated to useRollbar::report()
orRollbarLogger::report()
. There are a few exceptions where thelog()
method was still tested. To validate thatlog()
was working correctly a test helper classArrayLogger
was created that collects all verbose logs into an array in memory. Those logs can then be checked as a side effect of callinglog()
since it no longer returns anything.It is worth noting that there is still one outstanding behavior defined by
psr/log
that has not been implemented. #461 explains this. I will resolve that issue in a separate PR.Type of change
Related issues
Checklists
Development
Code review