From 2ecf70456ad9d1928c68b736efb4725fde892cac Mon Sep 17 00:00:00 2001 From: Christopher Dwyer-Perkins Date: Tue, 11 Jun 2024 10:40:42 -0300 Subject: [PATCH 1/4] Fixed error log printing when it shouldn't --- framework/src/source/TestRunner.bs | 1 + 1 file changed, 1 insertion(+) diff --git a/framework/src/source/TestRunner.bs b/framework/src/source/TestRunner.bs index e216b0d0..ee5d6dfd 100644 --- a/framework/src/source/TestRunner.bs +++ b/framework/src/source/TestRunner.bs @@ -163,6 +163,7 @@ namespace rooibos ? "Running suite asynchronously!" m.nodeContext.top.observeFieldScoped("rooibosSuiteFinished", "Rooibos_onTestSuiteComplete") testSuite.run() + return invalid else ? "Running suite synchronously!" testSuite.run() From a1035bdbca2f49160bd160507d31ec4bd83fcea3 Mon Sep 17 00:00:00 2001 From: Christopher Dwyer-Perkins Date: Tue, 11 Jun 2024 10:41:41 -0300 Subject: [PATCH 2/4] Fixed a bug where asyn tests that finish sync could result in problems --- framework/src/source/BaseTestSuite.bs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/framework/src/source/BaseTestSuite.bs b/framework/src/source/BaseTestSuite.bs index 5a031091..d3ad880d 100644 --- a/framework/src/source/BaseTestSuite.bs +++ b/framework/src/source/BaseTestSuite.bs @@ -199,6 +199,8 @@ namespace rooibos m.testRunner.top.unobserveFieldScoped("rooibosGroupFinished") ' m.testGroupDone() m.onAsyncGroupComplete(group) + else if m.testRunner.top.rooibosGroupFinished + m.onAsyncGroupComplete(group) end if end if From 091dff61b51602ef8433c234aefcdb0264ca246c Mon Sep 17 00:00:00 2001 From: Christopher Dwyer-Perkins Date: Tue, 11 Jun 2024 10:43:10 -0300 Subject: [PATCH 3/4] insure object key order when converting to string --- framework/src/source/CommonUtils.bs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/src/source/CommonUtils.bs b/framework/src/source/CommonUtils.bs index 9b9a6f51..38451201 100755 --- a/framework/src/source/CommonUtils.bs +++ b/framework/src/source/CommonUtils.bs @@ -334,7 +334,9 @@ namespace rooibos.common 'bs:disable-next-line isFirst = false end if - for each key in input + keys = input.keys() + keys.sort() + for each key in keys if rooibos.common.canSafelyIterateAAKey(input, key) text = text + key + ":" + rooibos.common.asString(input[key], includeType) end if From 514d57c5fa28a6ebbd6903dcac62914b189bcc77 Mon Sep 17 00:00:00 2001 From: Christopher Dwyer-Perkins Date: Tue, 11 Jun 2024 10:43:52 -0300 Subject: [PATCH 4/4] increased sleep at the end of the run to better flush the io logs --- framework/src/source/Rooibos.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/src/source/Rooibos.bs b/framework/src/source/Rooibos.bs index 2853a4a3..03b1108e 100644 --- a/framework/src/source/Rooibos.bs +++ b/framework/src/source/Rooibos.bs @@ -38,7 +38,7 @@ namespace rooibos ' leading to an instant exit of the application ' Give the io port time to finish sending all the logs - sleep(200) + sleep(400) end end if end if