Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax component property validations for .brs files #1301

Open
TwitchBronBron opened this issue Sep 23, 2024 · 0 comments · May be fixed by #1333
Open

Relax component property validations for .brs files #1301

TwitchBronBron opened this issue Sep 23, 2024 · 0 comments · May be fixed by #1333
Labels
bug Something isn't working
Milestone

Comments

@TwitchBronBron
Copy link
Member

For plain brightscript projects, we cannot show "can't find that property" errors on objects because these projects should not be forced to define brighterscript interfaces to exclude the errors. This is similar to how javascript handles things where in .js, objects can just flow and morph, but in .ts files they are very strict about the validations.

Here's an example. In .bs, the 3rd line should be an error. in .brs files, it should not be.

contentNode = CreateObject("RoSGNode", "ContentNode")
contentNode.addField("seasonIndex", "integer", false)
contentNode.seasonIndex = data.seasonIndex
@TwitchBronBron TwitchBronBron added the bug Something isn't working label Sep 23, 2024
@TwitchBronBron TwitchBronBron added this to the v1.0.0 milestone Sep 23, 2024
@markwpearce markwpearce linked a pull request Oct 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant