Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all the things #19

Open
rokroskar opened this issue Mar 10, 2021 · 4 comments
Open

Test all the things #19

rokroskar opened this issue Mar 10, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@rokroskar
Copy link
Owner

This action sorely needs some basic tests... see #16, for example.

@mustaphazorgati
Copy link
Collaborator

Hey @rokroskar!
Do you have any preferred way to test this action?

After a short search I found this repo which might help: https://github.com/bats-core/bats-core
The issue I see here is that we have to mock the github API somehow in order to properly test everything. Do you have and idea how that can be done?

@rokroskar
Copy link
Owner Author

Rewrite it in python and use pytest + mocking? :) I'm not sure how the mocking can be done with bash...

@mustaphazorgati
Copy link
Collaborator

Could be a viable solution. As of right now the bash script is very short.

@rokroskar
Copy link
Owner Author

Just looking at this - BATS could indeed be a great option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants