Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Common to Shared in the default rojo project #605

Closed
nezuo opened this issue Aug 3, 2022 · 2 comments · Fixed by #611
Closed

Rename Common to Shared in the default rojo project #605

nezuo opened this issue Aug 3, 2022 · 2 comments · Fixed by #611
Labels
type: enhancement Feature or improvement that should potentially happen

Comments

@nezuo
Copy link
Contributor

nezuo commented Aug 3, 2022

This is what rojo init generates by default:

"ReplicatedStorage": {
  "Common": {
    "$path": "src/shared"
  }
},

The name of the folder should match the name of the shared directory.

If this gets the go-ahead I can make a PR.

@LPGhatguy
Copy link
Contributor

This makes sense to me, these names should match.

That said, do you think there is a better naming scheme we can use for this folder?

@LPGhatguy LPGhatguy added the type: enhancement Feature or improvement that should potentially happen label Aug 3, 2022
@nezuo
Copy link
Contributor Author

nezuo commented Aug 3, 2022

Nothing comes to mind but all the projects I've seen have used Shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants