-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly render clientside templates #97
Open
megakoresh
wants to merge
10
commits into
rogeriopvl:master
Choose a base branch
from
megakoresh:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clientside templates will be named same as source files without extension, optionally adding `settings.suffix` to the end. Set options.filename to `file.basename` for caching (speeds up gulp watch task when working). New settings: `settings.suffix` - when `options.client` is `true`, appends the string provided to the end of the generated clientside template. Should fix issue rogeriopvl#96
Wow, you really have some crazy strict linting rules for such a small plugin! |
Finally, sheesh |
If `name` attribute function is specified in settings, it will be used to generate name of the client template. The name function gets a reference to `file`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clientside templates will be named same as source files without extension, optionally adding
settings.suffix
to the end.Set options.filename to
file.basename
for caching (speeds up gulp watch task when working).New settings:
settings.suffix
- whenoptions.client
istrue
, appends the string provided to the end of the generated clientside template.Should fix issue #96