New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate dispose cause the memory leak #400

Open

wwsheng009 opened this issue Dec 29, 2023 · 0 comments

wwsheng009 commented Dec 29, 2023

Isolate dispose cause the memory leak。

https://github.com/rogchap/v8go/blob/cee5f84bb54338bdef150b3e43daace4669c5de2/isolate.go#L147C1-L147C1

func (i *Isolate) Dispose() {
	if i.ptr == nil {
		return
	}
	C.IsolateDispose(i.ptr)
	i.ptr = nil
	i.cbs = nil //shoud release the cbs,otherwise the memory will leak。
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment