Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPUProfiler HitCount #283

Open
mnutt opened this issue Feb 7, 2022 · 1 comment
Open

CPUProfiler HitCount #283

mnutt opened this issue Feb 7, 2022 · 1 comment

Comments

@mnutt
Copy link

mnutt commented Feb 7, 2022

I was reading through how to use the CPUProfiler, but didn't quite understand how to interpret the output from the sample printTree method. It seems like it produces a call tree but doesn't show the relative weights? v8 profiler has a hitCount attribute that I believe provides the number of samples from that CPUProfilerNode, would it make sense to pass that through so that we can tally up self / total hits in the output? I'd be happy to make a PR if that seems correct.
@genevieve
Copy link
Collaborator

Yes, you're correct it would be great to have the other supported attributes exposed in the library. It was a TODO on the original PR that added the profiler: #167. Feel free to make a PR.

@ryanmurakami ryanmurakami mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnutt @genevieve