Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for yandesbrowser #127

Closed
omryr opened this issue May 8, 2017 · 6 comments
Closed

support for yandesbrowser #127

omryr opened this issue May 8, 2017 · 6 comments

Comments

@omryr
Copy link

omryr commented May 8, 2017

Hi i have issues when using yandexbrowser, im using your library through Radium.

when trying to load my website all the flex tags are not used so if something should be display: 'flex'
it wont appear in the browser.

yandex is built on top of chromium.

adding 'yandexbrowser' to webkit in vendorprefixes and to chrome array in browsers fixed most of the problems.

is there any way you could add support for it?

@neemah
Copy link

neemah commented May 15, 2017

Yes, it would be awesome, Yandex Browser user agent:
userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.137 YaBrowser/17.4.1.718 Yowser/2.5 Safari/537.36

It's chrome-based browser.

yandex-browser

@robinweser
Copy link
Owner

Can someone tell me the output of new Prefixer()._browserInfo for a Yandex browser? Yandex information is not shipped via caniuse, so I can't crawl feature support versions or anything, but we might pretend to be Chrome 0 to simply add all webkit prefixes.

@omryr
Copy link
Author

omryr commented May 15, 2017

do you mean this?
"{"name":"Yandex Browser","yandexbrowser":true,"version":17.4,"blink":true,"mac":true,"a":true,"prefix":{"inline":"Webkit","css":"-webkit-"},"browser":"chrome","osversion":null}"

@robinweser
Copy link
Owner

Do you have an example how e.g.

const style = {
  display: 'flex',
  flex: 1,
  justifyContent: 'flex-start'
}

is prefixed with a Yandex browser? It seems like it is already recognized as a Webkit-based browser...

@omryr
Copy link
Author

omryr commented May 22, 2017

adding flex gave me this: {
-webkit-box-align: stretch;
-webkit-box-direction: normal;
-webkit-box-orient: vertical;
}

@robinweser
Copy link
Owner

Ok got it. Looks like it detects the old flexbox spec while we would need to use the new one. We can force it to use the new one, but that might crash old Yandex versions. There's no other way to do it apparently, as we do not have a version mapping for those Yandex features on caniuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants