Fixed parallel installation issues

[pyromaniac]

Fixed parallel librarian-puppet install run issues such as: #132 or https://tickets.puppetlabs.com/browse/PUP-1609

This issued caused by shared module cache directory, so when one process cleanups it, the other one can not get its cached files anymore.

[p0deje]

👍

[carlossg]

thanks!

[carlossg]

since applying this I'm seeing new random errors in Travis about tar/gz, as if the module was not downloaded correctly
ie. https://travis-ci.org/rodjek/librarian-puppet/jobs/21421606

  Notice: Preparing to install into /home/travis/build/rodjek/librarian-puppet/tmp/aruba/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/apt/version/17b7ffb6cc1f3588d20dda49ffb651f0 ...
  Notice: Downloading from http://forge.puppetlabs.com ...
  Notice: Installing -- do not interrupt ...
  Error: Could not extract contents of module archive: Execution of 'tar xzf /home/travis/build/rodjek/librarian-puppet/tmp/aruba/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/apt/version/17b7ffb6cc1f3588d20dda49ffb651f0/cache/http_forge_puppetlabs_com-75a31f1d6f1ef6eb63b4479b3512ee1508209a7f/puppetlabs-apt-1.4.2.tar.gz --no-same-owner -C /home/travis/build/rodjek/librarian-puppet/tmp/aruba/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/apt/version/17b7ffb6cc1f3588d20dda49ffb651f0/cache/tmp-unpacker-224ca2fd5676c7b277056ed948d46fe1498cb4e3' returned 2: 
  gzip: stdin: unexpected end of file
  tar: Unexpected EOF in archive
  tar: Unexpected EOF in archive
  tar: Error is not recoverable: exiting now

  Error: Try 'puppet help module install' for usage

[pyromaniac]

Yeah, I see it too, but is it related to --module_working_dir?
I'll try to figure this out

[pyromaniac]

Ha, you have troubles with apt package too

[pyromaniac]

Looks like it's over. I suppose, it was a puppet forge temporary problems. Currently I've got no such a trouble over the last 24h having intensive parallel project builds. Could you check and confirm this restarting your builds?

[elovelan]

This is causing path length issues in Windows (the dreaded 260 character "feature"). Turns out Ruby does support Win32 File Namespaces (\\?\ format and requires backslashes) but since even File.join on Windows uses / as the path separator, this is going to be difficult to fix. I'll work on it, but I just wanted to put this out there in case anyone has any ideas.