-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git-based module with :ref=>"master" doesn't grab most current copy of code #141
Comments
I noticed some inconsistent behavior with my "workaround", where it was also downloading an older version of puppetlabs-apt. I did switch to using "git://" instead of "https://" for my path, hoping that might play a role, and also removed some unused modules from my Puppetfile; now it is grabbing the latest code form the master branch. Can anyone think of an explanation for why I'd experience this inconsistent behavior? I'll leave this bug open for now, as maybe there is something here that needs addressing. Let me know what others are thinking. |
I can't make head's or tail's of this problem I've described. It happens quite randomly from what I'm seeing: I startup several new VM's via Vagrant, all with the same Puppet manifests, and some will download puppetlabs-apt from my repo and other servers will download from PuppetLabs's repo. Here is my Puppetfile:
Here is my Librarian output:
|
I'd just like to bump this by saying that we're experiencing a very similar problem. We have a fork of the puppetlabs-apt Git repo and we're specifying a specific commit SHA. It looks like we're occasionally getting some other version of the repo and it's causing some failures. We're trying to get a test case that consistently fails but haven't been able to so far... |
Having similar/same issue. I have a ref to a branch but will not get the latest from that branch. I tried with both :ref "logs.core" and ref:/refs/remotes/origin/logs.core . sometimes it will get the right files. It's not even getting either master ref.
Installing role/1.0.0
[Librarian] --- No output
[Librarian] --- No output
[Librarian] --> e2e89b8a72cd5bfe7263fb71582f36a08a2783f6
[Librarian] Deleting modules/role
[Librarian] Copying .tmp/librarian/cache/source/git/97ce76625da10d3f to modules/role
|
as it was fixed when you removed the other dependencies, I'd say this is #181 a module comes from 2 different places with unexpected results |
With Librarian v0.9.10, I tried grabbing puppetlabs/apt from Github so that I could get a newer feature that hasn't made it into a tagged release yet, but when I try :ref=>'master', it seems to grab the last tagged version, thus not including my code.
Here's my Puppetfile entry:
mod "apt",
:git => "https://github.com/puppetlabs/puppetlabs-apt.git",
:ref => 'master'
Note: the workaround I did was use the SHA of the latest commit for this project (:ref=>'a350da76046b2d42f73ff6aed566adce1f13ff01'), which is probably a safer approach than using 'master'; however, I'm assuming this isn't the intended behavior of specifying a branch as ref. If it is intended, maybe update the documentation?
The text was updated successfully, but these errors were encountered: