Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linnting, isort and black as pre commit hooks #78

Open
jakobkolb opened this issue Nov 2, 2021 · 4 comments
Open

Add linnting, isort and black as pre commit hooks #78

jakobkolb opened this issue Nov 2, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jakobkolb
Copy link
Collaborator

To avoid unnecessary CI failures, do code formatting automatically. Also, run linting and reject commit if linting does not pass.

@benmaier
Copy link

benmaier commented Nov 2, 2021

how does automatic formatting work? is there a vim plugin?

@jakobkolb
Copy link
Collaborator Author

Well maybe there is a vim plugin, i wouldn't know. My preferred way is to install a formatter (I like black) and then, in your project directory, just run black .

@benmaier
Copy link

benmaier commented Nov 2, 2021

amazing, thanks

@jakobkolb jakobkolb added the enhancement New feature or request label Nov 3, 2021
@davhin
Copy link
Collaborator

davhin commented Nov 18, 2021

I have done black+flake8 pre-commit hook in the datenspende repo, I can take over this task

@davhin davhin self-assigned this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants