Fixed issue with Detroit having city name as "Houston" in NHL docs #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was my first ever contribution to a project. Hopefully, I followed all the contributing guidelines. Thanks for the awesome python package, I plan on using it for future projects! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a typo in the NHL docs. Under the Roster section, it used 'DET' as an example team. But in the comment below the example, it stated that it showed players for "Houston". I think it is fairly safe to say that Detroit is not the same as Houston,
and that this was just a mistake. I also updated some of the examples to be more up-to-date on the year, and instead of using a retired player from 2017-18 season, I replaced Zetterberg with Nathan Mackinnon.
Below is a current screenshot with the error.
