Fixed the issue that the update function isn't triggered when the con…

…tent of the sealed secrets has been updated
rockyhmchen · Feb 7, 2020 · efa1aa1 · efa1aa1
1 parent af5462e
commit efa1aa1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -11,7 +11,7 @@ GO_GET=$(GO_CMD) get
 all: clean build
 
 build: 
-	$(GO_BUILD) -o $(BINARY_NAME)_${VERSION} -v
+	$(GO_BUILD) -o $(BINARY_NAME)_v${VERSION} -v
 
 test: 
 	$(GO_GET) gotest.tools/gotestsum

diff --git a/sealedsecrets/resource_secret.go b/sealedsecrets/resource_secret.go
@@ -70,7 +70,6 @@ func resourceSecretCreate(d *schema.ResourceData, m interface{}) error {
 		return err
 	}
 
-	// d.SetId(utils.SHA256(ss.ModTime().Format(time.RFC3339)))
 	d.SetId(utils.SHA256(utils.GetFileContent(ssPath)))
 
 	return resourceSecretRead(d, m)
@@ -112,9 +111,12 @@ func resourceSecretRead(d *schema.ResourceData, m interface{}) error {
 		return nil
 	}
 
-	// ss, _ := os.Stat(ssPath)
-	// d.SetId(utils.SHA256(ss.ModTime().Format(time.RFC3339)))
-	d.SetId(utils.SHA256(utils.GetFileContent(ssPath)))
+	oldID := d.Id()
+	newID := utils.SHA256(utils.GetFileContent(ssPath))
+	if oldID != newID {
+		d.SetId("")
+		return nil
+	}
 
 	return nil
 }
@@ -155,7 +157,6 @@ func createSealedSecret(d *schema.ResourceData, mainCmd *Cmd) error {
 		utils.Log(errMsg)
 		return errors.New(errMsg)
 	}
-	// s, _ := os.Stat(sPath)
 
 	cert := d.Get("certificate").(string)
 	if !utils.PathExists(cert) {